Skip to content

Conversation

@JonathanOppenheimer
Copy link
Member

@JonathanOppenheimer JonathanOppenheimer commented Dec 31, 2025

Why this should be merged

Previously

Uncomment these tests when we have a way to run them in CI, currently we should not depend on Subnet-EVM as Coreth and Subnet-EVM have different release cycles. The problem is that once we update AvalancheGo (protocol version), we need to update Subnet-EVM to the same protocol version. Until then all Subnet-EVM tests are broken, so it's blocking Coreth development. It's best to not run these tests until we have a way to run them in CI.

However, with the mono-repo, coreth and subnet-evm now have identical release cycles (in fact, they quite literally have to!). So this is no longer a concern. Additionally the warp test is run in CI, so that is also no longer a concern.

This should not be merged until it's base PR (#4798) is merged. In addition #4795, should be merged so the genesis.json file does not need to be copied.

This should be merged as it adds some important test coverage IMO.

How this works

Uncomments the tests, copy and pastes necessary code from subnet-evm.

How this was tested

CI

Need to be documented in RELEASES.md?

No

@JonathanOppenheimer JonathanOppenheimer changed the base branch from master to JonathanOppenheimer/refactor-warp-e2e December 31, 2025 21:13
@JonathanOppenheimer JonathanOppenheimer added DO NOT MERGE This PR must not be merged in its current state evm Related to EVM functionality coreth Related to the former coreth standalone repository labels Dec 31, 2025
@JonathanOppenheimer JonathanOppenheimer self-assigned this Dec 31, 2025
@JonathanOppenheimer JonathanOppenheimer changed the title Jonathan oppenheimer/enable coreth subnet warp tests test: enable c-chain <-> subnet e2e warp tests Dec 31, 2025
Base automatically changed from JonathanOppenheimer/refactor-warp-e2e to master January 7, 2026 17:17
@JonathanOppenheimer JonathanOppenheimer marked this pull request as ready for review January 7, 2026 17:35
@JonathanOppenheimer JonathanOppenheimer requested a review from a team as a code owner January 7, 2026 17:35
@JonathanOppenheimer JonathanOppenheimer removed the DO NOT MERGE This PR must not be merged in its current state label Jan 7, 2026
Co-authored-by: Tsvetan Dimitrov <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
@JonathanOppenheimer JonathanOppenheimer force-pushed the JonathanOppenheimer/enable-coreth-subnet-warp-tests branch from 5c20d4a to aa30d82 Compare January 9, 2026 21:18
@JonathanOppenheimer
Copy link
Member Author

I reverted the last two commits of Tsvetan after Maru's comment.

@JonathanOppenheimer JonathanOppenheimer force-pushed the JonathanOppenheimer/enable-coreth-subnet-warp-tests branch from 64296dc to abe94e4 Compare January 13, 2026 15:56
@JonathanOppenheimer JonathanOppenheimer force-pushed the JonathanOppenheimer/enable-coreth-subnet-warp-tests branch from abe94e4 to b55fd11 Compare January 13, 2026 15:56
@maru-ava maru-ava added this pull request to the merge queue Jan 14, 2026
Merged via the queue into master with commit 4d835f9 Jan 14, 2026
57 of 58 checks passed
@maru-ava maru-ava deleted the JonathanOppenheimer/enable-coreth-subnet-warp-tests branch January 14, 2026 17:50
@github-project-automation github-project-automation bot moved this to Done 🎉 in avalanchego Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreth Related to the former coreth standalone repository evm Related to EVM functionality

Projects

Status: Done 🎉

Development

Successfully merging this pull request may close these issues.

6 participants